Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve success message when no product in compare page. #157

Closed
NishantSharma12 opened this issue Mar 6, 2024 · 2 comments
Closed

Improve success message when no product in compare page. #157

NishantSharma12 opened this issue Mar 6, 2024 · 2 comments
Assignees
@NishantSharma12
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@NishantSharma12
Copy link
Collaborator

Bagisto - v2.0.0

Bagisto-headless - v2.0.0

Message - "Warning: There is no product found."

API - Shop >> Compare Products >> Remove All Compare Products

Postman Screenshot
Screenshot from 2024-03-06 13-34-40

Web Screenshot

Screenshot from 2024-03-06 13-52-41
@NishantSharma12 NishantSharma12 added the bug Something isn't working label Mar 6, 2024
Anmol-Chauhan added a commit to Anmol-Chauhan/headless-ecommerce that referenced this issue Mar 8, 2024
@Anmol-Chauhan
bagisto#157 fixed
3aabdad
@NishantSharma12
Copy link
Collaborator Author

@Anmol-Chauhan please recheck this issue.

Bagisto - v2.0.0

Bagisto-headless - v2.0.0

API - Shop >> Compare Products >> Remove All Compare Products

Postman Screenshot

Screenshot from 2024-03-13 12-13-50

@Anmol-Chauhan Anmol-Chauhan added the invalid This doesn't seem right label Mar 13, 2024
@NishantSharma12
Copy link
Collaborator Author

Discussed with @Anmol-Chauhan will fix this issue in v2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NishantSharma12 NishantSharma12

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Anmol-Chauhan @NishantSharma12