Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error after updating Bagisto to 1.3.3 (from Product::getTypeInstance()) #44

Closed
funder7 opened this issue Oct 21, 2021 · 2 comments
Closed

Error after updating Bagisto to 1.3.3 (from Product::getTypeInstance()) #44

funder7 opened this issue Oct 21, 2021 · 2 comments

Comments

@funder7
Copy link
Contributor

funder7 commented Oct 21, 2021

Hi,

After updating my project by merging Bagisto v1.3.3, the project became broken due to this error:

> @php artisan package:discover

PHP Fatal error:  Declaration of Webkul\GraphQLAPI\Models\Catalog\Product::getTypeInstance() must be compatible with Webkul\Product\Models\Product::getTypeInstance(): Webkul\Product\Type\AbstractType in /var/www/html/packages/Webkul/GraphQLAPI/Models/Catalog/Product.php on line 21

I'm sending a PR in the next minutes to fix the issue.

Cheers!
@funder7 funder7 mentioned this issue Oct 21, 2021
Merged
vivek-webkul added a commit that referenced this issue Dec 1, 2021
@vivek-webkul
Merge pull request #45 from funder7/fix/bagisto_1.3.3-support
b731964 
#44 Fix - incompatible declaration Product::getTypeInstance()
@vivek-webkul
Copy link
Member

There are no such issues in the main branch, Closing this issue.

@funder7
Copy link
Contributor Author

funder7 commented Dec 8, 2021 •
edited
Loading

Have you tried to install the package into bagisto 1.3.3?
I did, and it was not running until this fix was applied (I'm using php 8.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@funder7 @vivek-webkul