Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Love this plugin, just need some additional features for it to be usable #21

Open
martynchamberlin opened this issue Aug 3, 2015 · 1 comment

Comments

@martynchamberlin
Copy link

First, would love to have basic data validation. Since it only supports CSV, we should be able to do this:

<input type="file" accept=".csv" />

So that at the HTML level there is only CSV types allowed. Right now the app just crashes if you try to upload, say, a .Numbers file.

Second, and more importantly, we really really need a callback function somehow that gets fired when the user selects the file. Otherwise we don't really have a way to handle file saving once it's been uploaded. I feel like this is so basic that I must be missing something here??

@bahaaldine
Copy link
Owner

Hey Martyn these are valuable and relevant features, I can have a look at it, meanwhile feel free to send a pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants