Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback attribute to execute after file is parsed #38

Merged
merged 1 commit into from
Jul 6, 2016

Conversation

AnnaKalkanis
Copy link

Addresses the second point in issue #21. A single callback function can now be passed into the directive as an attribute. The callback takes one parameter, which will be the event which triggered the file to be parsed (ie. change in file, change in separator...etc). The callback is executed once the file has been successfully parsed and the assignment of the parsed file to the 'result' variable has completed.

@samanthacatania
Copy link

I tried this commit and the callback was being called from strange places. I changed the argument callback to something else (in my case csvCallback) and the code started working as expected.

@JohnTheBeloved
Copy link

Can you kindly merge(if all is fine), Also need this feature asap

@bahaaldine bahaaldine merged commit 74f9224 into bahaaldine:master Jul 6, 2016
@bahaaldine
Copy link
Owner

Thanks for your help folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants