Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from magvar to geomag #11

Closed
wtip opened this issue Jul 18, 2020 · 5 comments · Fixed by #12
Closed

Switch from magvar to geomag #11

wtip opened this issue Jul 18, 2020 · 5 comments · Fixed by #12

Comments

@wtip
Copy link
Collaborator

wtip commented Jul 18, 2020

Let's switch over to https://github.com/janrg/wmm-geomagnetic

@janrg noticed an issue dpyeates/magvar#3 and fixed it in his fork

@brettz9
Copy link
Contributor

brettz9 commented Jul 19, 2020

I've started some work on a tool I hope to apply in a PR to this project which aims to check one's source and current npm dependencies for external script/stylesheet version and integrity info, so that when one updates dependencies (e.g., using the useful npm packages updates or npm-check-updates), one can safely auto-update the integrity SHAs and versioned URLs accordingly (without needing to consult the respective hosting source websites for checksums or manually editing the version numbers in the URLs).

I hope to apply that to that my PR for this project at the same time as adding Rollup (and @janrg's fork has the additional benefit of our not needing to add the Rollup CommonJS plugin).

@janrg
Copy link

janrg commented Jul 19, 2020

Renamed the package from wmm-geomagnetic to geomag

@wtip
Copy link
Collaborator Author

wtip commented Aug 3, 2020

@brettz9 How are your changes coming along? I'm wondering if I should apply an update to magvar in the meantime to get the issue fixed.

@brettz9
Copy link
Contributor

brettz9 commented Aug 4, 2020

Hi, @wtip . It's coming along--I have the project published now on npm and at https://github.com/brettz9/integrity-matters . However, I still want to add some features that I think may be of assistance to this project, e.g., to allow HTML data attributes and/or config which suggest a particular CDN to use for a particular package.

Though I intend to keep working on it, given that it may still take a little time, and I cannot, for health reasons, be very reliable in general in carrying through in a predictably timely manner, you may want to go ahead and update.

Note, however, if you go ahead, you'll need to make some API changes, e.g.:

  const magVar = Magvar.get(B.getLatLng().lat, B.getLatLng().lng);
  info.update(geodesic.statistics, magBearing(vector.initialBearing.toFixed(0), magVar));

to

  const {declination} = Geomag.field(B.getLatLng().lat, B.getLatLng().lng);
  info.update(geodesic.statistics, magBearing(vector.initialBearing.toFixed(0), declination));

@brettz9 brettz9 mentioned this issue Aug 7, 2020
@brettz9 brettz9 changed the title Switch from magvar to wmm-geomagnetic Switch from magvar to geomag Aug 7, 2020
@brettz9
Copy link
Contributor

brettz9 commented Aug 7, 2020

Filed #12 which should resolve this.

@wtip wtip closed this as completed in #12 Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants