-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from magvar to geomag #11
Comments
I've started some work on a tool I hope to apply in a PR to this project which aims to check one's source and current npm dependencies for external script/stylesheet version and integrity info, so that when one updates dependencies (e.g., using the useful npm packages I hope to apply that to that my PR for this project at the same time as adding Rollup (and @janrg's fork has the additional benefit of our not needing to add the Rollup CommonJS plugin). |
Renamed the package from wmm-geomagnetic to geomag |
@brettz9 How are your changes coming along? I'm wondering if I should apply an update to magvar in the meantime to get the issue fixed. |
Hi, @wtip . It's coming along--I have the project published now on npm and at https://github.com/brettz9/integrity-matters . However, I still want to add some features that I think may be of assistance to this project, e.g., to allow HTML data attributes and/or config which suggest a particular CDN to use for a particular package. Though I intend to keep working on it, given that it may still take a little time, and I cannot, for health reasons, be very reliable in general in carrying through in a predictably timely manner, you may want to go ahead and update. Note, however, if you go ahead, you'll need to make some API changes, e.g.: const magVar = Magvar.get(B.getLatLng().lat, B.getLatLng().lng);
info.update(geodesic.statistics, magBearing(vector.initialBearing.toFixed(0), magVar)); to const {declination} = Geomag.field(B.getLatLng().lat, B.getLatLng().lng);
info.update(geodesic.statistics, magBearing(vector.initialBearing.toFixed(0), declination)); |
Filed #12 which should resolve this. |
Let's switch over to https://github.com/janrg/wmm-geomagnetic
@janrg noticed an issue dpyeates/magvar#3 and fixed it in his fork
The text was updated successfully, but these errors were encountered: