Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache vs don't cache absolute filepaths #1

Open
kevinburkeshyp opened this issue Apr 26, 2015 · 3 comments
Open

cache vs don't cache absolute filepaths #1

kevinburkeshyp opened this issue Apr 26, 2015 · 3 comments

Comments

@kevinburkeshyp
Copy link

I wrote this: Shyp@f21238c

then realized it's not the right thing really... we don't care about absolute vs. relative, so much as we care about whether the path references something on the filesystem, or a module name..

For what it's worth I didn't see any measurable perf difference with this patch, but I wasn't rigorous about testing it.

@kevinburkeshyp
Copy link
Author

I wrote the right thing and it changes the test run time from 6-6.5s to 5.3-5.5s. Without the patch, the test run time is ~5.1s.

@bahmutov
Copy link
Owner

Did not look at this - is it worth incorporating this into the master?

@kevinburkeshyp
Copy link
Author

Prolly should do some more testing first... I didn't see much of a difference either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants