Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gif creation only for failed tests. #36

Open
rsudarson opened this issue Jul 2, 2020 · 3 comments
Open

Support gif creation only for failed tests. #36

rsudarson opened this issue Jul 2, 2020 · 3 comments

Comments

@rsudarson
Copy link
Collaborator

Provide option to create gifs only for failed tests from env configuration.
@rsudarson
Copy link
Collaborator Author

For a larger number of tests (say 100+), we can share gif as reproducer for test failures. I made changes to generate gif on test failures as well.
Please review 6a0d285

cc @bahmutov

@rsudarson
Copy link
Collaborator Author

@bahmutov - Can I merge this change?

@bahmutov
Copy link
Owner

So instead of just making gif of every failing test by default, why don't we look if this is required. I say grab the environment variable RECORD_FAILED_TESTS and if it is set, then generate (still using || against the test titles).

Then it would be nice and clear

@rsudarson rsudarson mentioned this issue Dec 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bahmutov @rsudarson