record on failures #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bahmutov - Please review, thanks! |
bahmutov
reviewed
Dec 18, 2020
| @@ -38,7 +40,7 @@ const processTestResults = (processingOptions = {}) => async (results) => { | |||
| } | |||
| // if the test name includes the special movie string | |||
| // then we want to convert this particular test into a movie | |||
| if (test.title[test.title.length - 1].includes(MOVIE_SYMBOL) || test.state === 'failed') { | |||
| if (test.title[test.title.length - 1].includes(MOVIE_SYMBOL) || recordFailedTests === 'true') { | |||
There was a problem hiding this comment.
so this will record all tests? because you removed the failed state check
bahmutov
reviewed
Dec 18, 2020
| @@ -16,6 +16,8 @@ const MOVIE_REGEX = /🎥/g | |||
|
|
|||
| const ffmpegPath = require('@ffmpeg-installer/ffmpeg').path | |||
|
|
|||
| const recordFailedTests = process.env.RECORD_FAILED_TESTS | |||
There was a problem hiding this comment.
process the environment variable here to get a boolean variable. I would do something like
let recordFailedTests = false
if ('RECORD_FAILED_TESTS' in process.env) {
recordFailedTests = process.env.RECORD_FAILED_TESTS === 'true' || process.env.RECORD_FAILED_TESTS === '1'
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address - #36