Skip to content

Commit

Permalink
fix: do not lose code 0 when filtering, close #4
Browse files Browse the repository at this point in the history
  • Loading branch information
bahmutov committed Apr 6, 2018
1 parent 9285a3c commit a469f1a
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 7 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
"dont-crack": "1.2.1",
"git-issues": "1.3.1",
"github-post-release": "1.13.1",
"lazy-ass": "1.6.0",
"license-checker": "15.0.0",
"mocha": "4.0.1",
"nsp": "2.7.0",
Expand Down
7 changes: 7 additions & 0 deletions src/execa-wrap-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,20 @@
const execaWrap = require('.')
const snapshot = require('snap-shot-it')
const os = require('os')
const la = require('lazy-ass')

if (os.platform() !== 'win32') {
describe('execa-wrap', () => {
it('ls', () => {
return execaWrap('ls', ['src']).then(snapshot.bind(null, 'ls src'))
})

it('filtering code 0', () => {
return execaWrap('ls', ['src'], { filter: 'code' }).then(output => {
la(output.indexOf('code: 0') !== -1, output)
})
})

it('failing', () => {
return execaWrap('boo', ['src']).then(snapshot.bind(null, 'boo src'))
})
Expand Down
14 changes: 7 additions & 7 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,28 @@ const makeFilteredText = result => {

// indent with 2 spaces every line
let message = ''
if (result.cmd) {
if ('cmd' in result) {
message += ` command: ${result.cmd}\n`
}
if (result.code) {
if ('code' in result) {
message += ` code: ${result.code}\n`
}
if (result.failed) {
if ('failed' in result) {
message += ` failed: ${result.failed}\n`
}
if (result.killed) {
if ('killed' in result) {
message += ` killed: ${result.killed}\n`
}
if (result.signal) {
if ('signal' in result) {
message += ` signal: ${result.signal}\n`
}
if (result.stdout) {
if ('stdout' in result) {
message += ` stdout:
-------
${result.stdout}
-------\n`
}
if (result.stderr) {
if ('stderr' in result) {
message += ` stderr:
-------
${result.stderr}
Expand Down

0 comments on commit a469f1a

Please sign in to comment.