feat(hooks): verifies that node is in PATH (#113)

* feat(hooks): verifies that `node` is in PATH * chore: better wording
bahmutov · Nov 1, 2017 · 46e73d1 · 46e73d1
1 parent 6bf31c2
commit 46e73d1
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 1 deletion.
diff --git a/hooks/commit-msg b/hooks/commit-msg
@@ -6,4 +6,9 @@ if [ ! -d "$DIRECTORY" ]; then
   exit -1
 fi
 
+if [ ! -x "$(command -v node)" ]; then
+  echo "Node binary not found, please ensure it has been properly installed"
+  exit -1
+fi
+
 ./node_modules/.bin/commit-msg "$@"
diff --git a/hooks/post-checkout b/hooks/post-checkout
@@ -5,6 +5,10 @@ if [ ! -d "$DIRECTORY" ]; then
   echo "WARNING: Cannot find node_modules folder, please run 'npm install' first"
 fi
 
-if [ -d "$DIRECTORY" ]; then
+if [ ! -x "$(command -v node)" ]; then
+  echo "WARNING: Node binary not found, please ensure it has been properly installed"
+fi
+
+if [ -d "$DIRECTORY" ] && [ -x "$(command -v node)" ]; then
   ./node_modules/.bin/post-checkout "$@"
 fi
diff --git a/hooks/post-commit b/hooks/post-commit
@@ -6,4 +6,9 @@ if [ ! -d "$DIRECTORY" ]; then
   exit -1
 fi
 
+if [ ! -x "$(command -v node)" ]; then
+  echo "Node binary not found, please ensure it has been properly installed"
+  exit -1
+fi
+
 ./node_modules/.bin/post-commit "$@"
diff --git a/hooks/post-merge b/hooks/post-merge
@@ -6,4 +6,9 @@ if [ ! -d "$DIRECTORY" ]; then
   exit -1
 fi
 
+if [ ! -x "$(command -v node)" ]; then
+  echo "Node binary not found, please ensure it has been properly installed"
+  exit -1
+fi
+
 ./node_modules/.bin/post-merge "$@"
diff --git a/hooks/pre-commit b/hooks/pre-commit
@@ -6,4 +6,9 @@ if [ ! -d "$DIRECTORY" ]; then
   exit -1
 fi
 
+if [ ! -x "$(command -v node)" ]; then
+  echo "Node binary not found, please ensure it has been properly installed"
+  exit -1
+fi
+
 ./node_modules/.bin/pre-commit "$@"
diff --git a/hooks/pre-push b/hooks/pre-push
@@ -6,4 +6,9 @@ if [ ! -d "$DIRECTORY" ]; then
   exit -1
 fi
 
+if [ ! -x "$(command -v node)" ]; then
+  echo "Node binary not found, please ensure it has been properly installed"
+  exit -1
+fi
+
 ./node_modules/.bin/pre-push "$@"