fix: do not throw if child process no longer exist

[mucsi96]

Fixes #46

[bahmutov]

@mucsi96 thank you for submitting this feature, is there are any chance a test could be added, something similar to "demo" scripts?

[mucsi96]

Sure. Probably with mocking I can do that. Will add it Today. Also I am wandering do we want to explicitly ignore this error type. Or it’s fine like this?

[bahmutov]

Or you could have a serve that immediately exits as soon as it starts and this tool asks it once. As far as ignoring - you could just log something to the console or debug message I think

…

Sent from my iPhone

On Oct 8, 2018, at 08:31, Igor Muchychka ***@***.***> wrote: Sure. Probably with mocking I can do that. Will add it Today. Also I am wandering do we want to explicitly ignore this error type. Or it’s fine like this? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[mucsi96]

I tried to come up with test you suggested without too much luck. Unfortunately it's not good if the server just immediately exits as it produces different exception. The child process should run until the psTree call and exit immediately after it - which is quite tricky without doing some complex mocking :)

[mucsi96]

Do you have any idea how can we write a test for this? Or can we merge this without a test?

[wlsf82]

@mucsi96, thanks for the fix. I'm using your fork for now.
Please notify when merging to the original repo so that I can go back to the official one.

[bahmutov]

Ok, I will merge the PR, and hope it fixes issue and does not introduce any new ones

[bahmutov]

🎉 This PR is included in version 1.7.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[mucsi96]

Thx!

[kentcdodds]

Thank you!!!! 💙💚💛💜