Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map markers calls on api #112

Closed
Falsal opened this issue May 15, 2024 · 4 comments
Closed

Fix map markers calls on api #112

Falsal opened this issue May 15, 2024 · 4 comments
Assignees

Comments

@Falsal
Copy link
Collaborator

Falsal commented May 15, 2024

Make sure that the calls for markers array is being done properly in both cases when search-term is there (raw knex query) and in case search-term is not included

@Falsal Falsal self-assigned this May 15, 2024
@Falsal
Copy link
Collaborator Author

Falsal commented May 17, 2024

loggers were added to test different cases of with and without search, it turns out this is an issue with the front end making multiple calls. See issue bahnzumberg/zuugle-suchseite#331

@Falsal Falsal closed this as completed May 17, 2024
@martinheppner martinheppner reopened this May 27, 2024
@Falsal
Copy link
Collaborator Author

Falsal commented May 29, 2024

Done: code checked and found the markers query is being properly done in both cases.

@Falsal Falsal closed this as completed May 29, 2024
@Falsal
Copy link
Collaborator Author

Falsal commented May 30, 2024

Added a NOTNULL condition for the markers query . So we would not have NULL values for the connection_arrival_stop_lon or connection_arrival_stop_lat sent to the FE.
Situation now: We could have mismatch between total number of tours and the number of markers on the FE
Potential solution : add the same condition to both cases (with or without search term), see "if(searchIncluded){ ...."

@Falsal
Copy link
Collaborator Author

Falsal commented May 31, 2024

on our meeting 31st May, the decision was to fix the data , so that we do not face the case when number of results for card container is different from the number of markers on the map. We also agreed to maintain the safe-guards (on api at least) for when such a case does come about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

No branches or pull requests

2 participants