Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search on frontend #331

Closed
Falsal opened this issue May 15, 2024 · 3 comments
Closed

Fix search on frontend #331

Falsal opened this issue May 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Falsal
Copy link
Collaborator

Falsal commented May 15, 2024

sometimes we do not get the right results, when we have the map (tested on production), is it due to FE issues ?
Remarks:
not stable results: for example when searching for "schneeberg" with city = "amstetten"
PROD : first attempt: on Start page pressing GO will give 0 total and no tiles.
from Main page: doing the same selection will give us a certain total and tiles which all seem to be the right ones.
after doing the step with Main page the

Dev/prod database:

UAT / smaller database

sometimes (when ?) the search with "silvester / amstetten" : produces 0 total but some tiles below it that are NOT the correct ones for the selection (see that by the default pic and when you open the detail page).

Image

Image

@Falsal Falsal added the bug Something isn't working label May 15, 2024
@Falsal Falsal self-assigned this May 15, 2024
@martinheppner
Copy link
Contributor

Possible way to find out the multiple queries:

Image

@Falsal
Copy link
Collaborator Author

Falsal commented May 17, 2024

Discoveries :
We checked the generated sql quarries and compared them with the expected results and they seem to match, at some cases the FE shows mismatched results. here are they:

  • The total tours is the main reference point. Remedy: the totalTours is now condition on the render of maps + MapBtn + CardContainer, i also added a no card text NoCards component . Requested after Friday meeting: remove the NoCards to limit the totalTours = 0 to card container meaning; if o totalTours then ONLY empty map will show
  • Search giving actual results PLUS remains of other tours : example with Innsbruck and "weg" as search term. The result on fast network page is 3 only (after multiple renders) where as on slow page it shows the 3 results followed with more cards from previous render of total cards. Remedy: the re-renders issue Remove unnecessary re-renders / page refresh #330 seems to be causing unnecessary calls to the backend and showing temp views. Currently searching for temporary solution for that.
  • mobile view : totalTours is 0 on search result when moving from start to main

@Falsal
Copy link
Collaborator Author

Falsal commented May 27, 2024

done

@Falsal Falsal closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants