Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty prefix usage #15

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Empty prefix usage #15

merged 1 commit into from
Oct 24, 2019

Conversation

FFKL
Copy link
Contributor

@FFKL FFKL commented Oct 24, 2019

I've add possibility to use empty prefix (empty string in options)

@bahung1221 bahung1221 merged commit e0095a8 into bahung1221:master Oct 24, 2019
@bahung1221
Copy link
Owner

Thank you very much @FFKL,
I will write some unit test for it now and then i will publish new version to npm tonight 👍

@FFKL
Copy link
Contributor Author

FFKL commented Oct 24, 2019

@bahung1221 I think, I'll add some type defs later 😄

@bahung1221
Copy link
Owner

It sound great!
I thought about typescript or coffeescript (#2) but it was delayed because i think this library has too little user, lol 😃

I'd appreciate PR, and i will go with you
Thanks

bahung1221 added a commit that referenced this pull request Oct 24, 2019
v2.0.6 - Allow redis empty prefix #15
@bahung1221
Copy link
Owner

By the way, your PR was published to npm as version v2.0.6 👍

@FFKL
Copy link
Contributor Author

FFKL commented Oct 24, 2019

@bahung1221 cool!

@FFKL FFKL deleted the dev branch October 24, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants