Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS async implementation #19

Merged
merged 1 commit into from
Oct 27, 2019
Merged

FS async implementation #19

merged 1 commit into from
Oct 27, 2019

Conversation

FFKL
Copy link
Contributor

@FFKL FFKL commented Oct 27, 2019

Hello! I reworked sync functions to async. I think, it needs more testing, but you can use it like basis for rework.

@FFKL
Copy link
Contributor Author

FFKL commented Oct 27, 2019

Also tests are unconsistent. Better to use beforeEach and afterEach (or something like this) for set up neccessary data and clean after testing 😄

@bahung1221
Copy link
Owner

Yes, I'm adding hook to clear test result, thank you so much 😄

@bahung1221 bahung1221 merged commit dc2b071 into bahung1221:master Oct 27, 2019
@bahung1221
Copy link
Owner

#18

@FFKL FFKL deleted the async-fs branch November 9, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FFKL @bahung1221