Skip to content

Commit

Permalink
[GLUTEN-5027][VL] Fail fast for unsupported compiler (apache#5030)
Browse files Browse the repository at this point in the history
Currently when unsupported compiler is detected, the build is not failed, just a message is logged, causing strange errors thrown later. By fail fast, it gives user a clear message what is going on.
  • Loading branch information
xumingming committed Mar 21, 2024
1 parent 1eac8be commit cbaa495
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
add_compile_options(-Wno-nullability-completeness)
add_compile_options(-Wno-mismatched-tags)
else()
message("Unsupported compiler ID: ${CMAKE_CXX_COMPILER_ID}")
message(FATAL_ERROR "Unsupported compiler ID: ${CMAKE_CXX_COMPILER_ID}")
endif()

# see https://issues.apache.org/jira/browse/ARROW-4665
Expand Down

0 comments on commit cbaa495

Please sign in to comment.