feat: Button-group-select支持统一配置所有选项角标 #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for this! Please review the labels and make any necessary changes. |
Dora-boots
changed the title
Dora-boots
force-pushed
the
master
branch
3 times, most recently
from
f5038c3
to
4eee230
Compare
lurunze1226
suggested changes
Apr 14, 2023
vite.config.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| import {defineConfig} from 'vite'; | |||
| import { defineConfig } from 'vite'; | |||
| const optionBadge = badge | ||
| ? option?.badge && typeof option?.badge === 'string' | ||
| ? {...badge, text: option.badge} | ||
| : option?.badge |
There was a problem hiding this comment.
这里应该判断是否为对象，因为badge可能为数字
There was a problem hiding this comment.
目前的设计，外层设置badge后，option内输入badge只会是string类型
| : button?.badge | ||
| ? {...badge, ...button.badge} | ||
| : null | ||
| : button.badge; |
There was a problem hiding this comment.
这个和上面的方法是一样的吧，可以统一一个方法
Dora-boots
force-pushed
the
master
branch
6 times, most recently
from
3cb1e65
to
b85dd64
Compare
lurunze1226
approved these changes
Apr 18, 2023
igrowp
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、支持button-group-select统一配置角标
2、支持option中配置角标，可覆盖统一配置
3、支持外层配置角标后，option中仅配置角标文案