feat: 图片上传外观配置 #6648
Merged
feat: 图片上传外观配置 #6648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for this! Please review the labels and make any necessary changes. |
qkiroc
approved these changes
Apr 20, 2023
lurunze1226
suggested changes
Apr 20, 2023
| icon="plus-fine" | ||
| className="icon" | ||
| iconContent={cx( | ||
| ':ImageControl-addBtn-icon', |
| classPrefix: ns | ||
| } = this.props; | ||
| const editorDefaultData = getValueByPath(editorPath, themeConfig); | ||
| const editorDefaultData = getValueByPath( | ||
| editorPath, |
There was a problem hiding this comment.
editorPath可以是一个组件内置的静态属性？不依赖外部传入
| const editorDefaultData = getValueByPath(editorPath, themeConfig); | ||
| const editorDefaultData = getValueByPath( | ||
| editorPath, | ||
| (window as any).themeConfig |
There was a problem hiding this comment.
themeConfig应该是一个从props.env下放的配置，不应该挂载在window上
added 3 commits
April 20, 2023 15:11
lurunze1226
approved these changes
Apr 24, 2023
hy993658052
pushed a commit
to hy993658052/amis
that referenced
this pull request
Apr 25, 2023
feat: 图片上传外观配置
qkiroc
added a commit
that referenced
this pull request
Apr 25, 2023
feat: 图片上传外观配置 Co-authored-by: qkiroc <30946345+qkiroc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
🤖 Generated by Copilot at 9867cd0
This pull request adds a feature to the
amisandamis-editorpackages that allows users to customize the style and icon of the input image control in the schema editor. It also simplifies some props and removes some redundant code in theInputTextandstyle-helperfiles. It updates the CSS files and theItemcomponent to support the new feature. It modifies theeditor.tsandThemeCssCode.tsxfiles to handle the theme configuration data and the compound selectors.🤖 Generated by Copilot at 9867cd0
Why
How
🤖 Generated by Copilot at 9867cd0
themeCssprop toItemcomponent to accept custom CSS styles from theme configuration (link)-iconcase toformatStylefunction to handle icon style properties in theme configuration (link)inputStateFuncfunction and constants to generate schema for input image control based on theme configuration and state (link)ImageControlPluginschema to allow user to customize appearance and style of input image control (link)insertCustomStyleimport and function call toInputImagecomponent to insert custom CSS styles from theme configuration (link, link)InputImagecomponent and its sub-elements to apply custom CSS styles and icon content (link, link, link)_components.scssand_image.scssfiles to define and style default icon for input image control (link, link, link, link, link, link)getCssAndSetValuefunction to handle compound selector with class selector for node selector (link)getValueByPathfunction fromstyle-helper.tsfile to avoid duplication (link)themeCssprop witheditorDefaultDataprop inMainStoreclass to store default values of theme configuration (link)filterSchemaForEditorfunction to check and assigneditorDefaultDataprop of schema based oneditorPathprop (link)getValueByPathfunction toutil.tsfile to provide utility function for getting default value of theme configuration by path (link)getValueByPathimport and useeditorDefaultDataprop instead inInputTextcomponent (link, link)--Timeline-visible-border-radiusvariable in_components.scssfile to improve readability and consistency (link)