Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:补充filter单测 #6952

Merged
merged 1 commit into from
May 22, 2023
Merged

fix:补充filter单测 #6952

merged 1 commit into from
May 22, 2023

Conversation

hsm-lv
Copy link
Collaborator

@hsm-lv hsm-lv commented May 22, 2023

What

🤖 Generated by Copilot at 7926ca8

This pull request improves the evaluation of formulas with asynchronous filters and adds a new test case for the resolveVariableAndFilter function. It refactors the AsyncEvaluator class in packages/amis-formula/src/evalutorForAsync.ts and updates the packages/amis-core/__tests__/filter.test.ts file.

🤖 Generated by Copilot at 7926ca8

Sing, O Muse, of the skillful coder who devised
New tests for the resolveVariableAndFilter function,
Which handles many filters with diverse arguments
And returns the right values with swift execution.

Why

How

🤖 Generated by Copilot at 7926ca8

  • Simplify and optimize the evaluation of formulas with asynchronous filters in AsyncEvaluator class (link, link)
  • Add a new test case for resolveVariableAndFilter function in packages/amis-core/src/utils/tpl-builtin.ts (link)

@hsm-lv hsm-lv requested a review from 2betop May 22, 2023 07:57
@github-actions github-actions bot added the fix label May 22, 2023
@github-actions
Copy link

👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.

Please review the labels and make any necessary changes.

@hsm-lv hsm-lv requested a review from nwind May 22, 2023 08:07
@hsm-lv hsm-lv merged commit 4063e43 into baidu:master May 22, 2023
5 checks passed
@hsm-lv hsm-lv deleted the fix-formula branch May 22, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants