Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amis-editor): layout:wrapper-contanier tpl 支持className设置 #7032

Merged
merged 3 commits into from
May 30, 2023

Conversation

wibetter
Copy link
Collaborator

@wibetter wibetter commented May 30, 2023

What

🤖 Generated by Copilot at e409de2

This pull request improves the code quality, layout, and internationalization of the AMIS editor. It formats and fixes the code of some components and functions, removes unnecessary styles and files, adds translations for new features, and allows customizing the configuration panels. It affects the files packages/amis-editor/src/renderer/ValidationControl.tsx, packages/amis-editor-core/scss/_rightPanel.scss, packages/amis-editor-core/scss/control/_validation-control.scss, packages/amis-editor-core/src/index.ts, packages/amis-editor/src/locale/en-US.ts, packages/amis-editor/src/locale/zh-CN.ts, packages/amis-editor/src/plugin/Form/ButtonGroupSelect.tsx, packages/amis-editor/src/renderer/textarea-formula/FormulaPicker.tsx, packages/amis-editor/src/tpl/layout.tsx, and packages/amis-editor/src/util.ts.

🤖 Generated by Copilot at e409de2

amis-editor
improves its style and layout
autumn of refactor

Why

How

🤖 Generated by Copilot at e409de2

  • Consolidate the styles related to the right sidebar of the editor in one file (link, link, link)
  • Remove the negative margin from the .config-wrapper-contanier class to improve the layout of the configuration panels (link)
  • Move the _validation-control.scss file to _rightPanel.scss to simplify the scss structure and reduce the bundle size (link)
  • Add a className parameter to the layout:wrapper-contanier schema template to allow custom class names for the container component (link)
  • Add translations for some new features or options added to the editor, such as icon size, initialization data interface, and table events (link, link)
    • Update the English locale file en-US.ts with the new entries (link)
    • Update the Chinese locale file zh-CN.ts with the new entries (link)
  • Format the code of some components and functions to follow the code style and lint rules of the project, and improve the code quality and readability (link, link, link, link, link, link)
    • Remove a trailing comma from the export statement in index.ts to avoid potential syntax errors or compatibility issues (link)
    • Format the code of the ButtonGroupControlPlugin class in ButtonGroupSelect.tsx (link)
    • Format the code of the renderValidateApiControl method and add parentheses around the return statement in ValidationControl.tsx (link, link)
    • Add an indentation to the FormulaEditor component in FormulaPicker.tsx (link)
    • Add a space before the ternary operator in the schemaToArray function in util.ts (link)

@wibetter wibetter requested review from igrowp and 2betop May 30, 2023 04:20
@wibetter wibetter changed the title Fix editor fix(amis-editor): layout:wrapper-contanier tpl 支持className设置 May 30, 2023
@wibetter wibetter merged commit d9bb67c into baidu:master May 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants