-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tabs组件title支持schema #7212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 Thanks for this! Please review the labels and make any necessary changes. |
sqzhou
force-pushed
the
feat/tabs-title-schema
branch
2 times, most recently
from
June 19, 2023 07:06
20e8048
to
ba1dc87
Compare
sqzhou
force-pushed
the
feat/tabs-title-schema
branch
from
June 19, 2023 07:10
4adb78e
to
099c9a6
Compare
sqzhou
force-pushed
the
feat/tabs-title-schema
branch
from
June 20, 2023 09:00
de6fba8
to
23a86ad
Compare
lurunze1226
approved these changes
Jun 20, 2023
wibetter
reviewed
Jun 20, 2023
hsm-lv
previously requested changes
Jun 20, 2023
wibetter
reviewed
Jun 20, 2023
wibetter
approved these changes
Jun 21, 2023
wibetter
dismissed
hsm-lv’s stale review
June 21, 2023 03:02
filter 中有判空,无需在这里进行重复的判空处理。filter(title, data) ?? render(tab-title/${index}, title, data) 改变了原有的逻辑,是有问题的写法。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
🤖 Generated by Copilot at aa61cec
This pull request enhances the
Tabs
component inamis-ui
andamis
packages. It fixes some touch-related bugs, allows non-string and dynamic tab titles, and supports schema-based tab rendering.🤖 Generated by Copilot at aa61cec
Why
How
🤖 Generated by Copilot at aa61cec
noop
function and use it as fallback for touch event handlers (link, link)title
prop type before callinghandleStartEdit
on double click (link)title
prop inTabSchema
to be either a string or aSchemaNode
(link)render
prop to render schema titles inrenderTabs
method (link)title
prop with data insourceTabs
array (link)title
prop toTab
component (link)