Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: condition-builder 弹窗模式支持 jssdk Close: #7324 #7329

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

2betop
Copy link
Collaborator

@2betop 2betop commented Jul 3, 2023

What

🤖 Generated by Copilot at 64fb2a0

Improved popover rendering for condition builder components. Added env and popOverContainer props to ConditionBuilder and ConditionPicker in ConditionBuilder.tsx to control where the popovers are appended.

🤖 Generated by Copilot at 64fb2a0

env and popOverContainer are the keys
To unleash the power of the condition builder
No matter where you nest it, it will render with ease
And let you create complex filters with skill and thrill

Why

Close: #7324

How

🤖 Generated by Copilot at 64fb2a0

  • Add env prop to ConditionBuilder component to access environment object (link)
  • Pass popOverContainer prop to ConditionPicker component using env.getModalContainer function to specify popover container element (link)

@github-actions github-actions bot added the chore label Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.

Please review the labels and make any necessary changes.

@lurunze1226 lurunze1226 merged commit 10ddff8 into baidu:master Jul 3, 2023
5 checks passed
@2betop 2betop deleted the chore-condition-builder-sdk branch July 3, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdk环境下 condition-builder 设置"embed": false,点击无法弹框
3 participants