Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 column static 属性影响到 quickEdit 中的问题 #8677

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

2betop
Copy link
Collaborator

@2betop 2betop commented Nov 9, 2023

What

🤖 Generated by Copilot at 8827c14

Renamed and propagated static prop of quick-edit-form renderer to allow more flexible control over form editability. Updated QuickEdit.tsx and related files.

🤖 Generated by Copilot at 8827c14

To make forms more consistent and neat
static prop had to face defeat
It became defaultStatic
A change quite pragmatic
For editability state to complete

Why

How

🤖 Generated by Copilot at 8827c14

  • Rename static prop of quick-edit-form renderer to defaultStatic to avoid confusion with form-item renderer (link)
  • Pass down defaultStatic prop from quick-edit-form renderer to form-item and form renderers to inherit default editability state (link, link)
  • Update QuickEdit.tsx file to reflect the prop name change and pass down the prop value (link, link, link)

@github-actions github-actions bot added the fix label Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.

Please review the labels and make any necessary changes.

@2betop 2betop changed the title fix: 修复 column static 属性影响到 quickEdit 中问题 fix: 修复 column static 属性影响到 quickEdit 中的问题 Nov 9, 2023
@2betop 2betop merged commit 7f92c30 into baidu:master Nov 9, 2023
2 of 3 checks passed
@2betop 2betop deleted the fix-static branch November 9, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants