Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(amis-editor): Form配置面板中表达式使用变量,避免data被赋值导致取值错误 #8680

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

lurunze1226
Copy link
Collaborator

@lurunze1226 lurunze1226 commented Nov 9, 2023

What

🤖 Generated by Copilot at a165991

This pull request improves the code quality and fixes a bug in the amis-editor plugin. It simplifies some visibleOn expressions in Form.tsx and ensures the filter button is always visible in CRUD.tsx.

🤖 Generated by Copilot at a165991

We'll fix the bugs and make the code shine
With template literals and visibleOn fine
Heave away, me hearties, heave away
We'll pull the request and sail another day

Why

How

🤖 Generated by Copilot at a165991

  • Fix filter button visibility bug in CRUDPlugin by using template literals for features (link)
  • Simplify visibleOn expressions for source setting forms in FormPlugin by using template literals for feat and dsType (link, link)
  • Add return statement to arrow function for consistency in FormPlugin (link)

@github-actions github-actions bot added the chore label Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.

Please review the labels and make any necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants