Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crud编辑器提示导致报错问题修复 #8806

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

wanglinfang2014
Copy link
Collaborator

@wanglinfang2014 wanglinfang2014 commented Nov 20, 2023

What

🤖[deprecated] Generated by Copilot at 59526d5

This pull request improves the performance and functionality of the CRUD and CRUD2 renderers in amis. It fixes a pagination bug in the CRUDStore, removes redundant imports, and uses faster equality checks to avoid unnecessary re-rendering.

🤖[deprecated] Generated by Copilot at 59526d5

Oh we're the jolly coders of the CRUD2 renderer
We slice and dice the data with a flick of our finger
We don't need no deep equality to slow us down
We use the strictest checks to make our app run sound

Why

How

🤖[deprecated] Generated by Copilot at 59526d5

  • Fix pagination bug in CRUDStore by checking items length before slicing (link)
  • Optimize performance of CRUD and CRUD2 renderers by using strict equality check for data comparison (link, link)
  • Remove unused import of isEqual from CRUD2.tsx (link)

@github-actions github-actions bot added the fix label Nov 20, 2023
Copy link

👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.

Please review the labels and make any necessary changes.

@lurunze1226 lurunze1226 merged commit 4fd601a into baidu:master Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants