chore: flex布局设置优化 #9949
Merged
chore: flex布局设置优化 #9949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for this! Please review the labels and make any necessary changes. |
wibetter
reviewed
Apr 1, 2024
| const resizer = context.resizer; | ||
| const frameRect = parent.getBoundingClientRect(); | ||
| const rect = dom.getBoundingClientRect(); | ||
| const isFlexItem = this.manager?.isFlexItem(node.id); | ||
| const isColumnFlex = String(host?.schema?.style?.flexDirection).includes( |
There was a problem hiding this comment.
判断当前元素是否是flex（垂直排列方向）直接子元素有现成的方法：
const isFlexColumnItem = this.manager.isFlexColumnItem(context.id)。
2betop
approved these changes
Apr 1, 2024
wibetter
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How