Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close incomplete blocks #181

Merged
merged 9 commits into from
Feb 4, 2016
Merged

Close incomplete blocks #181

merged 9 commits into from
Feb 4, 2016

Conversation

lylei
Copy link
Collaborator

@lylei lylei commented Feb 2, 2016

No description provided.

for (std::set<int64_t>::iterator it = blocks.begin(); it != blocks.end(); ++it) {
close_blocks->Add(*it);
}
close_blocks->Add(0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥加个0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

手误手误。。。

@bluebore
Copy link
Collaborator

bluebore commented Feb 2, 2016

build

2 similar comments
@lylei
Copy link
Collaborator Author

lylei commented Feb 2, 2016

build

@bluebore
Copy link
Collaborator

bluebore commented Feb 2, 2016

build

@@ -72,10 +73,11 @@ class BlockMapping {

typedef std::map<int32_t, std::set<int64_t> > CheckList;
CheckList recover_check_;
typedef std::map<int32_t, std::set<int64_t> > IncompleteList;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个IncompleteList和上面的checklist不是一个类型么

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在是的,怕后面会改

volatile int deleted_;

FileCache* file_cache_;
std::map<int32_t, Callback> slide_window_callbacks_;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

求改个名字

bluebore added a commit that referenced this pull request Feb 4, 2016
Close incomplete blocks
@bluebore bluebore merged commit fe53cae into baidu:master Feb 4, 2016
@lylei lylei deleted the close branch February 5, 2016 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants