2.0 to master #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.add the convert of ListProto to java List and MapProto to java Map 3.modify the uuid strategy 4.register highflip runtime oject 5.complete HighFlipService 6.add highflip.adaptor.service.properties
chen-zhiyu
requested changes
Aug 9, 2023
| @@ -1,7 +1,7 @@ | |||
| ######################################################### | |||
| # highflip adaptor | |||
| ######################################################### | |||
| highflip.server.adaptor.path= | |||
| highflip.server.adaptor.path=file:/Users/songtingyu/tmp/fate_adaptor/highflip-adaptor-fate-1.0.0-SNAPSHOT-jar-with-dependencies.jar | |||
| Iterator<Highflip.TaskListResponse> response = Streams | ||
| .stream(getEngine().listTask(request.getJobId())) | ||
| .stream(getEngine().listTask(job.getBingingId())) |
There was a problem hiding this comment.
bindingid是不确定的，在server中不能参考此数值
| @@ -559,6 +561,15 @@ message ConfigListResponse{ | |||
| string key = 1; | |||
| } | |||
|
|
|||
| message GetServiceConfigResponse{ | |||
There was a problem hiding this comment.
这块可以后面考虑收到config中，其它厂商是不一定有这个定义
chen-zhiyu
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.