mqtt based file delivery sdk #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popduke
reviewed
Sep 26, 2022
iotcore-file-delivery/pom.xml
Outdated
| <version>3.0.8</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> |
There was a problem hiding this comment.
as SDK, don't hardcode logging framework, let users choose it
popduke
reviewed
Sep 26, 2022
iotcore-file-delivery/pom.xml
Outdated
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>11</source> |
There was a problem hiding this comment.
the project POMs are quite messy and hard to maintain. pls take some time to re-structure it following some guideline/convention/best practices
2. add some docs for better communication; 3. add checkstyle and spotbugs for formatting and checking.
2. add README.md for each module.
2. format README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.