Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加钉钉机器人告警。 #342

Merged
merged 3 commits into from Apr 6, 2022
Merged

Conversation

fedocx
Copy link

@fedocx fedocx commented Mar 8, 2022

@CaledoniaProject
Copy link
Collaborator

你好,以前的钉钉报警是不能用了吗,我不是很清楚这俩啥区别

@fedocx
Copy link
Author

fedocx commented Mar 8, 2022

你好,以前的钉钉报警是不能用了吗,我不是很清楚这俩啥区别

以前的钉钉是能用的。不过钉钉webhook 机器人更灵活,可以在自建的内部群里面发送告警信息,也是我们这边大量使用的告警通知方式。

@CaledoniaProject
Copy link
Collaborator

好的,我明天看下

@CaledoniaProject
Copy link
Collaborator

		if (len(alarmType) == 0 || alarmType[0] == "ding") && app.DingRobotAlarmConf.Enable {
			PushDingRobotAttackAlarm(app, total, alarms, isTest)
		}

这个是不是写错了?应该是 == ding_robot?

@fedocx
Copy link
Author

fedocx commented Mar 9, 2022

@fedocx fedocx closed this Mar 9, 2022
@fedocx
Copy link
Author

fedocx commented Mar 9, 2022

		if (len(alarmType) == 0 || alarmType[0] == "ding") && app.DingRobotAlarmConf.Enable {
			PushDingRobotAttackAlarm(app, total, alarms, isTest)
		}

这个是不是写错了?应该是 == ding_robot?

这块是想着复用钉钉的告警开关,所以alarmType和页面的报警类型配置没有为ding_robot单独添加

@CaledoniaProject CaledoniaProject changed the base branch from master to 1.3.8 April 6, 2022 11:20
@CaledoniaProject CaledoniaProject merged commit 41d495d into baidu:1.3.8 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants