Skip to content

Commit

Permalink
remove tagName toLowerCase, allow pascal word as subcomponent name
Browse files Browse the repository at this point in the history
  • Loading branch information
errorrik committed Nov 24, 2021
1 parent bb61cc5 commit 5f5bb03
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 4 deletions.
3 changes: 0 additions & 3 deletions src/parser/parse-template.js
Expand Up @@ -71,9 +71,6 @@ function parseTemplate(source, options) {
var tagMatchStart = walker.index - tagMatch[0].length;
var tagEnd = tagMatch[1];
var tagName = tagMatch[2];
if (!svgTags[tagName]) {
tagName = tagName.toLowerCase();
}

// 62: >
// 47: /
Expand Down
32 changes: 31 additions & 1 deletion test/component.spec.js
Expand Up @@ -756,6 +756,36 @@ describe("Component", function () {
document.body.removeChild(wrap);
});

it("components with pascal tagName allowed", function () {
var Label = san.defineComponent({
template: '<span title="{{text}}">{{text}}</span>',
initData: function () {
return {
text: 'erik'
}
}
});

var MyComponent = san.defineComponent({
components: {
'Label': Label,
},
template: '<div><Label/></div>'
});

var myComponent = new MyComponent();

var wrap = document.createElement('div');
document.body.appendChild(wrap);
myComponent.attach(wrap);

var span = wrap.getElementsByTagName('span')[0];
expect(span.title).toBe('erik');

myComponent.dispose();
document.body.removeChild(wrap);
});

it("components use s-is", function () {
var Label = san.defineComponent({
template: '<span title="{{text}}">{{text}}</span>',
Expand Down Expand Up @@ -3248,7 +3278,7 @@ describe("Component", function () {
expect(e.oldValue.email).toBe(oldEmail);
expect(e.newValue).toBe(value);
expect(this.data.get('projects[0].author.email')).toBe(value.email);

watchTriggerTimes++;
});

Expand Down

0 comments on commit 5f5bb03

Please sign in to comment.