remove genElementChildren

baidu · Feb 22, 2019 · df7492a · df7492a
1 parent bb56e8b
commit df7492a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 34 deletions.
diff --git a/src/view/component.js b/src/view/component.js
@@ -738,7 +738,12 @@ Component.prototype._repaintChildren = function () {
         this.children = [];
 
         this.slotChildren = [];
-        genElementChildren(this);
+
+        for (var i = 0; i < this.aNode.children.length; i++) {
+            var child = createNode(this.aNode.children[i], this);
+            this.children.push(child);
+            child.attach(this.el);
+        }
     }
 };
 
@@ -838,7 +843,11 @@ Component.prototype._attach = function (parentEl, beforeEl) {
         insertBefore(this.el, parentEl, beforeEl);
 
         if (!this._contentReady) {
-            genElementChildren(this);
+            for (var i = 0; i < this.aNode.children.length; i++) {
+                var child = createNode(this.aNode.children[i], this);
+                this.children.push(child);
+                child.attach(this.el);
+            }
             this._contentReady = 1;
         }
     }

diff --git a/src/view/gen-element-children.js b/src/view/gen-element-children.js
diff --git a/src/view/node-own-only-children-attach.js b/src/view/node-own-only-children-attach.js
@@ -9,7 +9,6 @@
 
 
 var insertBefore = require('../browser/insert-before');
-var genElementChildren = require('./gen-element-children');
 
 
 /**
@@ -23,7 +22,11 @@ function nodeOwnOnlyChildrenAttach(parentEl, beforeEl) {
     this.sel = document.createComment(this.id);
     insertBefore(this.sel, parentEl, beforeEl);
 
-    genElementChildren(this, parentEl, beforeEl);
+    for (var i = 0; i < this.aNode.children.length; i++) {
+        var child = createNode(this.aNode.children[i], this);
+        this.children.push(child);
+        child.attach(parentEl, beforeEl);
+    }
 
     this.el = document.createComment(this.id);
     insertBefore(this.el, parentEl, beforeEl);