Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update types #393

Merged
merged 1 commit into from
Mar 12, 2019
Merged

update types #393

merged 1 commit into from
Mar 12, 2019

Conversation

LeuisKen
Copy link
Contributor

#392

@yenshih 帮忙看一下

@coveralls
Copy link

coveralls commented Mar 11, 2019

Pull Request Test Coverage Report for Build 700

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.235%

Totals Coverage Status
Change from base Build 699: 0.0%
Covered Lines: 2480
Relevant Lines: 2611

💛 - Coveralls

Copy link
Contributor

@yenshih yenshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -67,7 +70,7 @@ declare namespace San {
[k: string]: (value: any, ...filterOption: any[]) => any,
};
components?: {
[k: string]: ComponentConstructor<{}, {}> | SanComponentConfig<{}, {}> | 'self',
[k: string]: ComponentConstructor<{}, {}> | SanComponentConfig<{}, {}> | SanComponentLoader<{}, {}> | 'self',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Record

@@ -8,7 +8,8 @@ declare namespace San {

type SanEventListener<T, N> = (e: SanEvent<T, N>) => any;
interface SanData<T> {
parent: SanComponent<T>;
new(data?: {}, parent?: SanData<{}>);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new 后面应该要空格吧,不知道这里规范如何

@errorrik errorrik merged commit 30e4ce2 into baidu:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants