chore: add listeners and messages types for san.component #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinzhan
reviewed
Feb 9, 2022
types/index.d.ts
Outdated
| @@ -95,6 +95,9 @@ declare namespace san { | |||
|
|
|||
| nodeType: NodeType.CMPT; | |||
| lifeCycle: LifeCycleStage; | |||
|
|
|||
| listeners: ComponentListener<T>[]; | |||
There was a problem hiding this comment.
这里的listeners应该是object不是array
zhixinbao
reviewed
Feb 9, 2022
types/index.d.ts
Outdated
| @@ -95,6 +95,9 @@ declare namespace san { | |||
|
|
|||
| nodeType: NodeType.CMPT; | |||
| lifeCycle: LifeCycleStage; | |||
|
|
|||
| listeners: ComponentListener<T>[]; | |||
| messages: ComponentDefineOptionMessages | |||
jinzhan
reviewed
Feb 9, 2022
types/index.d.ts
Outdated
| @@ -469,6 +472,11 @@ declare namespace san { | |||
| nodeType: NodeType.SLOT; | |||
| } | |||
|
|
|||
| interface ComponentListener<T> { | |||
| fn: DataChangeListener<T>; | |||
There was a problem hiding this comment.
ComponentListener 和 DataChangeListener不是一个东西，this的指向不同
jinzhan
requested changes
Feb 9, 2022
types/index.d.ts
Outdated
| @@ -469,6 +472,13 @@ declare namespace san { | |||
| nodeType: NodeType.SLOT; | |||
| } | |||
|
|
|||
| interface ComponentListener<T> { | |||
| [k: string]: { | |||
| fn: (this: Component<T>, change: DataChangeInfo) => void; | |||
There was a problem hiding this comment.
fn 的参数是 event 啊，这个跟 Data 的listener是2个东西，别混淆了，https://github.com/baidu/san/blob/master/src/view/component.js#L471
Pull Request Test Coverage Report for Build 1816984829
💛 - Coveralls |
|
listeners 和 messages 不用加在 component 声明里。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
补充 Component 的 listeners 和 messages 属性的类型