fix junit test and javadoc error #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tullyliu
reviewed
Oct 8, 2022
| * Decode byte of the Protocol to MsgBase. Parsing protocol only, not parsing body. Execute in io thread. | ||
| * <1>Determine the data type: Request or Response</1> <2>Decode the byte to MsgBase</2> <3>Throw CodecException</3> | ||
| * Decode byte of the Protocol to MsgBase. Parsing protocol only, not parsing body. Execute in io thread. 1. | ||
| * Determine the data type: Request or Response 2. Decode the byte to MsgBase 3. Throw CodecException |
tullyliu
reviewed
Oct 8, 2022
| * {@link #encodeBody(MsgBase)} <1>Determine the data type: Request or Response</1> <2>Encode the MsgBase to | ||
| * ByteBuf</2> <3>Throw CodecException</3> | ||
| * {@link #encodeBody(MsgBase)} 1.Determine the data type: Request or Response 2.Encode the MsgBase to ByteBuf | ||
| * 3.Throw CodecException |
tullyliu
reviewed
Oct 8, 2022
| @@ -158,10 +158,10 @@ public static InetAddress getLocalAddress() { | |||
| } | |||
|
|
|||
| /** | |||
| * check if is a valid address <1> not null </1> <2> not loopbackip </2> <3> not 0.0.0.0 or 127.0.0.1 </3> | |||
| * check if is a valid address 1. not null 2. not loopbackip 3. not 0.0.0.0 or 127.0.0.1 | |||
tullyliu
reviewed
Oct 8, 2022
| * {@link #createMapping(Class, Object)}</1> <2> According to the mapping relationship, map HttpRequest to MethodHandler | ||
| * {@link #handler(HttpServletRequest)}</2> <3> Convert HttpRequst to method params | ||
| * {@link #resolveArguments(HandlerMethod, HttpServletRequest, HttpServletResponse)} </3> Used in | ||
| * {@link RpcRequest}. Step1: Store the mapping relationship between Method and RequestMappingInfo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.