Skip to content

Commit

Permalink
Updated to fix grammatical and punctuation issues (#93)
Browse files Browse the repository at this point in the history
* Updated to fix grammatical and punctuation issues

feat: Grammatical and punctuation updates

1. Added missing quote in the second instance of close at line number 88
2. Corrected walkthrough as it is a single word
3. Updated line number 152 for grammatical mistake

* Added links and updated as per comments

Co-authored-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
  • Loading branch information
nehbehl and baijum committed Oct 24, 2020
1 parent f557fce commit a893286
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions source/getting-started.rst
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ ensure that some results are found, make an assertion::
assert "No results found." not in driver.page_source

Finally, the browser window is closed. You can also call `quit` method instead
of `close`. The `quit` will exit entire browser whereas close` will close one
of `close`. The `quit` will exit entire browser whereas `close` will close one
tab, but if just one tab was open, by default most browser will exit entirely.::

driver.close()
Expand All @@ -96,8 +96,8 @@ Using Selenium to write tests

Selenium is mostly used for writing test cases. The `selenium` package itself
doesn't provide a testing tool/framework. You can write test cases using
Python's unittest module. The other options for a tool/framework are py.test
and nose.
Python's unittest module. The other options for a tool/framework are `pytest <https://docs.pytest.org/en/stable/>`_
and `nose <https://nose.readthedocs.io/en/latest/>`_.

In this chapter, we use `unittest` as the framework of choice. Here is the
modified example which uses unittest module. This is a test for `python.org`
Expand Down Expand Up @@ -141,15 +141,15 @@ You can run the above test case from a shell like this::
The above result shows that the test has been successfully completed.


Walk through of the example
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Walkthrough of the example
~~~~~~~~~~~~~~~~~~~~~~~~~~

Initially, all the basic modules required are imported. The `unittest
<http://docs.python.org/library/unittest.html>`_ module is a built-in Python
based on Java's JUnit. This module provides the framework for organizing the
test cases. The `selenium.webdriver` module provides all the WebDriver
implementations. Currently supported WebDriver implementations are Firefox,
Chrome, Ie and Remote. The `Keys` class provide keys in the keyboard like
Chrome, IE and Remote. The `Keys` class provides keys in the keyboard like
RETURN, F1, ALT etc.

::
Expand Down Expand Up @@ -269,4 +269,3 @@ dictionaries, you can specify the values explicitly::
desired_capabilities={'browserName': 'htmlunit',
'version': '2',
'javascriptEnabled': True})

0 comments on commit a893286

Please sign in to comment.