BLE improvements #80
Merged
BLE improvements #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Inspection fixes: - Discovering new device means we could find New valid device/service (couple validity check with search) so changes to ServiceInterface, BleSensorSDK18, CscService, HeartRateService, BatteryService. - When we buffer messages send to sensor, try to keep order: use FIFO rather than LIFO so changes to Executer Try to reconnect while riding with click or on disconnect (get far and comme back...) so changes to CockpitActivity, CockpitView, SensorService , AppBroadcaster, Connector Improve new sensor discovery: - Make selective scan to reduce sensor list to sort: so changes to BleScannerSDK21 - speed up new service association during scann: so changes to BleSensorsSDK18, SensorItemState This improve significantly BLE discovery and keep connection, it would be worth in future to decouple "configuration" vs run time states
|
Thank you for this contribution. |
bailuk
added a commit
that referenced
this pull request
Oct 19, 2019
…), display message to user when reconnecting
bailuk
added a commit
that referenced
this pull request
Oct 19, 2019
…is with SensorStateButton in MainActivity
bailuk
added a commit
that referenced
this pull request
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Inspection fixes:
Discovering new device means we could find New valid device/service (couple validity check with search) so changes to ServiceInterface, BleSensorSDK18, CscService, HeartRateService, BatteryService.
When we buffer messages send to sensor, try to keep order: use FIFO rather than LIFO so changes to Executer
Ease operation:
Improve new sensor discovery:
This improve significantly BLE discovery and keep connection, it would be worth in future to decouple "configuration" vs run time states
In relation with challanges highlighted in issues:
#78
#61
few improvements, few discovery and association challenges remains,
decouple configuration states and run time states.
e.g. do we need to space messages?
sorry for confusion it is simply change:
b087bdd