Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "max page height" option that will forcibly break pages off at a given pixel height #25

Closed
bajuwa opened this issue Mar 11, 2020 · 2 comments
Closed

Add a "max page height" option that will forcibly break pages off at a given pixel height #25

bajuwa opened this issue Mar 11, 2020 · 2 comments
Labels
Argument Involves adding/modifying one of the arguments for the main command line script Comicom The main Comic Compiler script that performs the stitching enhancement New feature or request wontfix This will not be worked on

Comments

@bajuwa
Copy link
Owner

bajuwa commented Mar 11, 2020 •
edited
Loading

This is an MVP solution for art heavy series that don't have many available breakpoints.

This should still try to crop at a point that hopefully does not contain text/bubbles. That may mean doing a naive check for presence of both black and white in the middle 60% of the image (to avoid detecting black borders on panels over a white backdrop.
@bajuwa bajuwa added enhancement New feature or request good first issue Good for newcomers Comicom The main Comic Compiler script that performs the stitching Argument Involves adding/modifying one of the arguments for the main command line script labels Mar 11, 2020
@bajuwa
Copy link
Owner Author

bajuwa commented Mar 27, 2020 •
edited
Loading

Also keep in mind this problem of handling 'orphans'
#39 (comment)

@bajuwa bajuwa added this to the Pre-Python milestone Mar 27, 2020
@bajuwa bajuwa removed the good first issue Good for newcomers label Mar 28, 2020
@bajuwa bajuwa self-assigned this Mar 28, 2020
@bajuwa bajuwa removed this from the Pre-Python milestone Mar 28, 2020
@bajuwa bajuwa removed their assignment Mar 28, 2020
@bajuwa bajuwa added the wontfix This will not be worked on label Apr 5, 2020
@bajuwa
Copy link
Owner Author

bajuwa commented Apr 5, 2020

Marking this as 'won't fix' (at least for now) as there are other features/improvements to the splitting logic that may help alleviate the original problem of "pages too long" without increasing risk of splitting text as much as a hard cut.

@bajuwa bajuwa closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Argument Involves adding/modifying one of the arguments for the main command line script Comicom The main Comic Compiler script that performs the stitching enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bajuwa