Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an argument to allow the last compiled page to 'adopt' up to X remaining images even if it's already hit a valid breakpoint #39

Closed
bajuwa opened this issue Mar 24, 2020 · 2 comments
Assignees
Labels
Argument Involves adding/modifying one of the arguments for the main command line script bug Something isn't working Comicom The main Comic Compiler script that performs the stitching enhancement New feature or request

Comments

@bajuwa
Copy link
Owner

bajuwa commented Mar 24, 2020

This will combat scenarios where the final compiled page is just a single image or two, and it would have been more beneficial to add them to the previous page instead of having them be a page all on their own.

@bajuwa bajuwa added bug Something isn't working enhancement New feature or request Comicom The main Comic Compiler script that performs the stitching Argument Involves adding/modifying one of the arguments for the main command line script labels Mar 24, 2020
@bajuwa bajuwa added this to the Pre-Python milestone Mar 24, 2020
@bajuwa
Copy link
Owner Author

bajuwa commented Mar 27, 2020

This may conflict with the concept of 'maximum height' that is also requested. This ticket could be modified to instead behave like this: After hitting the minimum height, if the total remaining height of all remaining images would still result in a page under the maximum height then 'adopt' those orphaned pages as well.

This would, however, need to define which is the stronger requirement: If the min height is reached, but the remaining orphans result in a page taller than the max height, but they also do not reach the min-height for a standalone page, what do we do?
My current preference/proposal would be to continue current behaviour: min-height of the last page is not strict

@bajuwa
Copy link
Owner Author

bajuwa commented Apr 24, 2020

The issue was resolved by adding a new field that mimics 'minimum height per page' but specifically applies to the last page. All height formats from 'per page' also apply for 'last page'. and GUI has been updated to include this field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argument Involves adding/modifying one of the arguments for the main command line script bug Something isn't working Comicom The main Comic Compiler script that performs the stitching enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant