This repository has been archived by the owner on Oct 3, 2022. It is now read-only.
Improve now playing banner #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakape
approved these changes
Feb 10, 2021
client/main.ts
Outdated
| localStorage.setItem("eden", "true") | ||
| break | ||
| default: | ||
| const flags = parseInt(nowPlaying, 10) |
There was a problem hiding this comment.
It's amazing how this still works with nowPlaying=null.
There was a problem hiding this comment.
NaN is converted to 0 in bitwise contexts. That migration should only run if nowPlaying exists however. Good catch.
|
Please resolve conflicts and I'll merge it. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite banners as independent objects
The current implementation is fragile. Because updates are performed sequentially, an inaccessible API blocks all radios from updating until the fetch times out. Likewise, an unhandled exception in an unmarshalfn will abort the update for all stations.
The new implementation:
Horizontal banner option
Stacked banners waste screen space and many users prefer the original layout. While this can be fixed by the user with custom CSS, an official option is more convenient.
This option is enabled by default to match how the banner used to be displayed. As pointed out in PR #1241, horizontal banners can be problematic on small screens. I believe the majority of users have enough screen width that this isn't a problem. Those that don't can easily turn it off.
Eden default streamer
Eden Radio lacks a bot streamer name. This is inconsistent with the other banners so I've added a default.