Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper file extension detection #52

Closed
Chiiruno opened this issue Mar 12, 2019 · 7 comments
Closed

Improper file extension detection #52

Chiiruno opened this issue Mar 12, 2019 · 7 comments
Labels

Comments

@Chiiruno
Copy link
Collaborator

Screenshot_20190312_092500

@Chiiruno Chiiruno added the bug label Mar 12, 2019
@medukatheguca
Copy link

for _, ext := range [...]string{".png", ".jpg", ".jpeg", ".webp"} {
ext to lowercase will fix the issue

@bakape
Copy link
Owner

bakape commented Mar 12, 2019

Since when are upper case extensions allowed?

@medukatheguca
Copy link

medukatheguca commented Mar 12, 2019

You can upload an archive with uppercase extensions inside which I guess don't get checked by the thumbnailer the same way they normally do as single files.

@bakape
Copy link
Owner

bakape commented Mar 13, 2019 via email

@medukatheguca
Copy link

Here's a reference of an archive of pngs and an archive of PNGs

@bakape
Copy link
Owner

bakape commented Mar 13, 2019

PEBCAK

@bakape bakape closed this as completed Mar 13, 2019
@Chiiruno
Copy link
Collaborator Author

Yes, however it's a simple enough fix to accommodate said problem without a real performance penalty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants