-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper file extension detection #52
Labels
Comments
Line 113 in 0b14c80
|
Since when are upper case extensions allowed? |
You can upload an archive with uppercase extensions inside which I guess don't get checked by the thumbnailer the same way they normally do as single files. |
There is no reason it should be rejected based on the extension, but I
should also not accommodate user retardation.
…On Tue, 12 Mar 2019 at 21:38, medukatheguca ***@***.***> wrote:
You can upload an archive with uppercase extensions which I guess doesn't
get checked yet by the thumbnailer.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHfPsB_olDtba5HIflLwAAk7xyiAJfGcks5vWAIogaJpZM4brCdL>
.
|
PEBCAK |
Yes, however it's a simple enough fix to accommodate said problem without a real performance penalty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: