allow for spaces in paths for windows

[simonmcconnell]

fixes #118
type command fails silently, resulting in an empty executable

[jjcarstens]

Thanks @simonmcconnell!

I'm hesitant to merge this because type was introduced recently to fix a different issue in compiling the CPIO on Windows. So it seems like this will fix one specific case, but break the others

What it also seems like is that Windows has quite an extensive array of environment setups that really affect compilation of the tools and resulting executable but our simple :os.type checks aren't specific enough in those cases.

I don't know enough about Windows to make a decision here so I would love feedback if you have an idea how best to handle these env differences. Maybe if its windows we System.find_executable("type") and if thats nil, we try cat?

[simonmcconnell]

I believe it was me that changed cat to type originally. Looking into the empty exe issue this morning I could not get type to work for the paths output by bakeware, but I think it it just the / in the path.

You're right, if you run type in mingw you get a different type to the one in the command prompt. I'll have to look into it further when I've got a spare few hours. Maybe I was too quick on the trigger with this PR because I introduced the bug 🤭.

[jjcarstens]

@simonmcconnell Whats the status of this? Is there more investigation to be done?

[simonmcconnell]

@jjcarstens I tested it on git bash, PowerShell and CMD prompt so I'm happy.

Do you think it's worth adding the three different shells to CI? If that's even possible.

[jjcarstens]

O absolutely - If its even possible (and I'm not doing it 😉 ) then I would love all 3 in CI

[simonmcconnell]

Ya bloody slacker! This is open source therefore you do everything free 😉

I'll play with the CI options in a test repository and report back.

[jjcarstens]

Thanks! I think we'll go ahead and merge this and I'll make a release in a bit.

If you (or someone) happens to get that CI magic, we'll put that in later