Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point operations from serde #15

Closed
renatoalencar opened this issue Apr 13, 2023 · 0 comments · Fixed by #19
Closed

Floating point operations from serde #15

renatoalencar opened this issue Apr 13, 2023 · 0 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@renatoalencar
Copy link

When running make debug I receive the following output:

cargo build --package tez_kernel --target wasm32-unknown-unknown --profile release --target-dir ./target/repl
    Finished release [optimized] target(s) in 0.32s
wasm-strip -o ./.bin/debug_kernel.wasm ./target/repl/wasm32-unknown-unknown/release/tez_kernel.wasm
docker run --rm -it --entrypoint=/bin/sh --name wasm-repl -v $PWD/.bin:/.bin tezos/tezos:master_f9675b19_20230303221946 -c '/usr/local/bin/octez-smart-rollup-wasm-debugger /.bin/debug_kernel.wasm --inputs /.bin/inputs.json'
Error
  Unknown exception: Error(_, "float instructions are forbidden")

make: *** [debug] Error 1

Running grep -nE 'f(32|64)\.' ./.bin/kernel.wat I can find a few occurrences of floating point instructions, and looking into the wat file I could find the following functions, with mangled names:

I'm not sure how to solve this, but I believe we could do something with conditional compilation directly on serde, since cfg(no_integer128) (example https://github.com/serde-rs/serde/blob/master/serde/src/de/mod.rs#L121) opens this possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants