0.6.0: Error syncing DHCP server config #272
Labels
bug
Something isn't working
Comments
|
If I update my config from Config # replicas instances (optional, if more than one)
replicas:
# url of the replica instance
- url: http://redacted:8085
username: redacted
password: redactedLog |
bakito
added a commit
that referenced
this issue
Jan 13, 2024
|
Hi @golles can you please provide debug logs of the second configuration? |
|
With the second configuration, do you mean the adguard home replica? Myabe I should mention that I've got 2 servers, the main AGH is running on the 1st, the 2nd AGH and sync are running on the 2nd server. All applications run in docker containers. |
|
2nd is the config with |
|
debug logs |
|
Logs from 2nd instance The last line repeats many times after that |
|
Do you have dhcp configuration enabled in you AdguatdHome master? If not, try disabling the DHCP feautures. |
|
I don't have DHCP configured. With hat config I get the same error: |
bakito
added a commit
that referenced
this issue
Jan 14, 2024
* correct config issues #271 #272 * rename type tags * replace env lib * move to config module * read flags * show e2e logs on error * extract env * replace deprecated env var * increment index * check replica numbers do not start with 0 * remove test suite * error handling * refactor flags * flags test * file test * file test * config tests * extend tests * test mixed mode * simplify * simplify * test mask * correct uniqe replicas * Update types_test.go * e2e test with file mode
|
Can you please try your config with the newest main image |
bakito
added a commit
that referenced
this issue
Jan 14, 2024
|
The main looks good, with no errors. Thanks! |
|
Without this config features:
dhcp:
serverConfig: false
staticLeases: falseThe error persists in 0.6.1 |
|
It's the the same as you tested in main. |
|
I had that config still there when testing on main, with that config it is working fine. AGH logs: Sync: Config: # cron expression to run in daemon mode. (default; "" = runs only once)
cron: "*/10 * * * *"
# runs the synchronisation on startup
runOnStart: true
origin:
# url of the origin instance
url: http://srv1:8085
# apiPath: define an api path if other than "/control"
insecureSkipVerify: true # disable tls check
username: redacted
password: redacted
# replicas instances (optional, if more than one)
replicas:
# url of the replica instance
- url: http://srv2:8085
username: redacted
password: redacted
# Configure the sync API server, disabled if api port is 0
api:
# Port, default 8080
port: 8080
# if username and password are defined, basic auth is applied to the sync API
# username: username
# password: password
# Configure sync features; by default all features are enabled.
# features:
# generalSettings: true
# queryLogConfig: true
# statsConfig: true
# clientSettings: true
# services: true
# filters: true
# dhcp:
# serverConfig: true
# staticLeases: true
# dns:
# serverConfig: true
# accessLists: true
# rewrites: true |
|
Please try v0.6.2 - I could reproduce the issue and fix it in my tests |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
After updating from version
0.5.4to0.6.0I see this error.Rolling back doesn't show this error.
AdguardHome-Sync Version
0.6.0
AdguardHome Version
v0.107.43
Configuration
Relevant log output
2024-01-12T18:36:16.790+0100 INFO root cmd/root.go:119 Using config file:/config/adguardhome-sync.yaml 2024-01-12T18:36:16.806+0100 INFO sync sync/sync.go:38 AdGuardHome sync {"version": "v0.6.0", "build": "2024-01-10T18:53:37Z", "os": "linux", "arch": "arm64"} 2024-01-12T18:36:16.808+0100 INFO sync sync/sync.go:65 Setup cronjob {"cron": "*/10 * * * *", "next-execution": "2024-01-12T18:40:00.000+0100"} 2024-01-12T18:36:16.809+0100 INFO sync sync/sync.go:75 Running sync on startup 2024-01-12T18:36:16.810+0100 INFO sync sync/http.go:57 Starting API server {"port": 8080} 2024-01-12T18:36:16.827+0100 INFO sync sync/sync.go:172 Connected to origin {"from": "redacted:8085", "version": "v0.107.43"} 2024-01-12T18:36:16.920+0100 INFO sync sync/sync.go:271 Start sync {"from": "redacted:8085", "to": ""} 2024-01-12T18:36:17.396+0100 INFO sync sync/sync.go:279 Connected to replica {"from": "redacted:8085", "to": "", "version": "v0.107.43"} 2024-01-12T18:36:19.807+0100 INFO client client/client.go:337 Set stats config {"host": "", "interval": 7} 2024-01-12T18:36:20.262+0100 INFO client client/client.go:269 Toggle filtering {"host": "", "enabled": true, "interval": 24} 2024-01-12T18:36:21.348+0100 INFO client client/client.go:396 Set dhcp server config {"host": ""} 2024-01-12T18:36:21.505+0100 ERROR sync sync/sync.go:300 Error syncing DHCP server config {"from": "redacted:8085", "to": "", "error": "400 Bad Request(bad dhcpv4 configuration: dhcpv4: invalid IP is not an IPv4 address\n)"} github.com/bakito/adguardhome-sync/pkg/sync.(*worker).syncTo /go/src/app/pkg/sync/sync.go:300 github.com/bakito/adguardhome-sync/pkg/sync.(*worker).sync /go/src/app/pkg/sync/sync.go:259 github.com/bakito/adguardhome-sync/pkg/sync.Sync.func3 /go/src/app/pkg/sync/sync.go:76Anything else?
In the log, some
toandhostseem to be empty.The text was updated successfully, but these errors were encountered: