Remove separator from tableviews

[elland]

• Table view should not be responsible for cell design.

[elland]

Merging now so I can move on with work. 🙆

[3lvis]

Sounds like something project specific. Could you move this change to your project instead?

[elland]

No, this is architecture. Having the tableview be responsible for drawing the cell separator makes no sense. This should've been deprecated years ago, certainly legacy from iPhoneOS still.

[3lvis]

I would understand if a lot of people could disagree with you, including @marijnschilling and me. Please roll back.

[elland]

I don't understand what you mean. 🤔

[3lvis]

I'm saying that this is not a good default. And that we should roll back since @marijnschilling and me don't agree with this.

[3lvis]

Since this is a change that needs some discussion, I'm going to roll it back so we can discuss it properly.

[marijnschilling]

Where we will discuss it? Here? I have arguments up my sleeve

[elland]

Here is fine, for posterity. I agree that it's an ugly default, but it is the default. Having the tableview have separators make absolutely no sense to me, it's such a clear violation of responsibilities, but go on.

[marijnschilling]

I think tableView should be responsible for separators because separators say something about how the cells relate to eachother (i.e: last cell doesnt show separator etc.) It's not something a cell can decide for itself.

[elland]

last cell doesnt show separator

1. The iOS default has separators even when there are no cells.
2. Since when? Also you can tell the cell to show or not show an element based on arbitrary logic. Telling what it should display should come from the model/controller, actually laying it out shouldn't. It's the equivalent of having the table view controller setting the cell's title label colour. It's leaking. 🤔

[3lvis]

You're proposing to draw the separators inside the cells instead, @elland?

[elland]

Where else would you draw a cell subview? They're not cell separators, they are decoration inside the cell.

[elland]

This shows more clearly when you need a decorator that is not supported by the tableview out of the box. Do you subclass the tableview to override the separator drawing or do you set it to .none and add a separator subview to the cell? 🤔