[[Set]] or [[DefineOwnProperty]]?

[Loirooriol]

Array.from creates properties with CreateDataPropertyOrThrow, which relies on [[DefineOwnProperty]].

Object.assign uses Set, which relies on [[Set]].

Which one is more appropriate for Object.fromEntries?

[bathos]

I think you’re correct, CreateDataPropertyOrThrow is likely more appropriate because we already know the target object has no special [[Set]] behaviors to account for.

[Loirooriol]

https://github.com/bakkot/object-from-entries/blob/53993dcbfca226d3f91d5b83a41d9657be2fa7ee/DETAILS.md#L102-L104

@bakkot [[DefineOwnProperty]] is not consistent with Object.assign, which does trigger setters on Object.prototype.

[mathiasbynens]

@Loirooriol Object spread ({ ...object }) does not trigger setters.

[Loirooriol]

@mathiasbynens I know, and I prefer it if Object.fromEntries does not trigger setters either, but Object.assign does, and DETAILS.md says it doesn't.

[bakkot]

@Loirooriol Whoops, thanks, fixed.