-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests needed #5
Comments
Hi, thank you for your enquiry. As a matter of fact, the code in this repo is not really maintained, as you may have noticed. The actual code has been written in just two afternoons or so last year, and since then no refactoring has been done. The reason is that we have written the codes to ensure that all the code our team write can be version controlled which was an important issue in those days. Since then somehow our entire workflow has been changed, we switched from Python to Scala and although we still use Jupyter notebooks, albeit with different kernels, their importance somewhat decreased. Nevertheless, we got several inquiries, even pull requests which shows that making easier to version control Jupyter notebooks is an important issue not just for us. The refactoring and the tests you refer to were actually part of a job interview or something similar, as far as I know. I have no problems with that rewriting, the main reason that it was largely ignored is that we simply do not have enough time to keep the code updated but because of the popularity of the repo I think it would be great if we could maintain the code base properly. |
Hi, Thanks for your elaborate answer. As it happens, I'm looking into version control using Jupyter notebooks, so perhaps I will fork the repo and perform the necessary work for maintainance myself. Thank you for the nice repo in any case, I'm sure it will be useful :) |
I propose adding tests do this repository. Since Jupyter might change its API's at any time with the introduction of new versions, as we've seen in the past, your conversion scripts only last as long as the time the current version supports it.
If a new version of Jupyter would be released with breaking changes, at least the tests will reflect this and we can update accordingly. Your method of notebook version control is the most promising to date, but you still have a pull request waiting that would add tests: #1. How do you feel about merging it?
The text was updated successfully, but these errors were encountered: