SnmpTrapdParser: Fix tm_hour differences in outgoing messages came from snmptrapd() source #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitzkia
changed the title
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
@kira-syslogng retest this please test branch=micek_timezone_for_ose; |
|
Build FAILURE, the tests were executed on test branch: micek_timezone_for_ose and test suite: functions |
mitzkia
force-pushed
the
normalize_mktime_one_hour_diff
branch
from
bbb05ce
to
fd7d85f
Compare
|
Build FAILURE, the tests were executed on test branch: micek_timezone_for_ose and test suite: functions |
mitzkia
force-pushed
the
normalize_mktime_one_hour_diff
branch
from
fd7d85f
to
558731e
Compare
|
Build FAILURE, the tests were executed on test branch: micek_timezone_for_ose and test suite: functions |
mitzkia
force-pushed
the
normalize_mktime_one_hour_diff
branch
from
558731e
to
e3dd143
Compare
|
Build FAILURE, the tests were executed on test branch: micek_timezone_for_ose and test suite: functions |
mitzkia
force-pushed
the
normalize_mktime_one_hour_diff
branch
from
e3dd143
to
4b9e1a6
Compare
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
…om snmptrapd() source * The difference happened when the date of the incoming message is in summer time, and the localtime is in winter time. Timezone: Europe/Budapest * Example date from incoming message: 2017-05-11 16:07:17 * Wrong date in outgoing message: 2017-05-11 17:07:17 * Fixed date in outgoing message: 2017-05-11 16:07:17 * Added unit test fixes Signed-off-by: Andras Mitzki <andras.mitzki@balabit.com>
mitzkia
force-pushed
the
normalize_mktime_one_hour_diff
branch
from
4b9e1a6
to
ceacc93
Compare
mitzkia
changed the title
bazsi
approved these changes
Nov 6, 2017
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a one hour difference when a incoming timestamp is in DST and a local time is in winter time, and the local timezone is not CEST.
The issue can be reproduced with snmptrapd-source.
Signed-off-by: Andras Mitzki andras.mitzki@balabit.com
Signed-off-by: Gabor Nagy gabor.nagy@balabit.com