cmake: disable_all_modules support #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `-DENABLE_IPV6=no`, this unit test does not compile. Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
This does not work: as there are other test that depend on it, but the guard is missing around them. In autotools, this module is not switchable. So we get closer to the autotools version. Basicfuncs has no external dependency, and we typically make modules modules switchable, if they have such dependency. Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
|
Build SUCCESS |
Kokan
reviewed
Mar 26, 2019
furiel
changed the title
-DDISABLE_ALL_MODULES=yes will disable all switchable modules Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
furiel
force-pushed
the
cmake-disable-all-modules
branch
from
2c74e06
to
ddfc1b5
Compare
furiel
changed the title
|
Build SUCCESS |
lbudai
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-DDISABLE_ALL_MODULES=yesspecified for cmake, all switchable modules are disabled by default. One can still override specific modules by:-DDISABLE_ALL_MODULES=yes -DENABLE_PYTHON=yes. The order of definitions do not matter.-DENABLE_IPV6=noresulted in compile error in a unit test.-DENABLE_BASICFUNCS, as it causes compile error in some unit tests, it is not switchable in autotools, and does not have any external dependencies.