Fix zoneinfo parser #2898
Merged
Fix zoneinfo parser #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on tzcode 2019b. Signed-off-by: László Várady <laszlo.varady@balabit.com>
Signed-off-by: László Várady <laszlo.varady@balabit.com>
Based on tzcode 2019b. Signed-off-by: László Várady <laszlo.varady@balabit.com>
Based on tzcode 2019b. Signed-off-by: László Várady <laszlo.varady@balabit.com>
|
|
|
Build SUCCESS |
|
please base your work on my timezone rewrite stuff, because that contains
some refactoring steps too. thanks
…On Sat, Aug 31, 2019 at 12:52 AM László Várady ***@***.***> wrote:
zone_info_parser() is huge, I'm going to extract each step into a
separate method.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2898>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFOK5Q7YXS3W44HVTAJB43QHGQBJANCNFSM4ISRVBEA>
.
--
Bazsi
|
bazsi
approved these changes
Sep 10, 2019
|
We have a lot of PRs open, I don't want to keep this open. I'd rather send another PR with the refactor later, but only after I reviewed a few others :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes assumptions from the zoneinfo parser that are no longer true (based on tzcode 2019b).
Fixes #2819